G-FED Download The "Newsprint" Theme Follow @MGageMorgan 

 
M. Gage Morgan's Federated Blog

    The Difference Between Constructive Criticism and Showing Off

M. Gage Morgan   on August 3, 2017
Categories: Uncategorized

  

When I ask for comments on my code, don’t be a suicide-bomber-refactorer. Yes, I said that. As I’ve learned, refactoring shouldn’t be done just for the sake of doing it. It should be done in a well-commented way so that when you forgot what that structure does in four months, you can come back and still have it broken down. 

As I’ve learned in 2015, people go from constructive to show-off in a heartbeat if given the opportunity. If I didn’t write my code a certain way, it’s because the language feature you wanted me to use was too abstract to come back to in a few months’ time.